Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract pool implementation to dedicated shard #190

Open
Blacksmoke16 opened this issue Oct 10, 2023 · 1 comment
Open

Extract pool implementation to dedicated shard #190

Blacksmoke16 opened this issue Oct 10, 2023 · 1 comment

Comments

@Blacksmoke16
Copy link
Member

Extracted from https://forum.crystal-lang.org/t/http-client-and-fibers/6068/5, it feels a bit strange that the db shard has a quite robust pool implementation, but in order to use it you have to require a shard that you may otherwise have no reason to use. It would make more sense if the pool was broken out into its own shard, and then required by db.

I did a quick look and think the main challenge would be dealing with the exception types. db would have to rescue/re-raise its own errors, or we make it a minor breaking change and just tell people to update the rescues to the new pool implementation types.

@jgaskins
Copy link
Contributor

Previous discussion of this is in #122.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants