Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New market API uses doubles #504

Closed
theoreticalbts opened this issue Jan 7, 2016 · 0 comments
Closed

New market API uses doubles #504

theoreticalbts opened this issue Jan 7, 2016 · 0 comments

Comments

@theoreticalbts
Copy link
Contributor

The new market API implemented as part of #503 uses doubles. Use of doubles in any financial system is a worst practice, and this situation should be corrected. If #246 is finally implemented we should isolate the double's into their own API.

An alternative version is to refactor the JSON code to take a parse_float function pointer, like Python's JSON parser, and then have the floats parsed as some kind of rational or string class that doesn't lose information.

@vikramrajkumar
Copy link
Contributor

This issue was moved to bitshares/bitshares-core#144

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants