Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package dependencies blank #6

Open
jkolyer opened this issue Feb 22, 2020 · 2 comments
Open

Package dependencies blank #6

jkolyer opened this issue Feb 22, 2020 · 2 comments

Comments

@jkolyer
Copy link

jkolyer commented Feb 22, 2020

assert and Buffer are both referenced by the code, but not by packages.json. This implied dependency is not indicated anywhere so you must spend time to debug why you're getting errors.

Better option is copy the 10 lines of code directly and avoid the hassle.

@Runrioter
Copy link

They are built-in modules/objects.

@jkolyer
Copy link
Author

jkolyer commented Feb 22, 2020

They are built-in modules/objects.

If you're using node.js. But not if you're running the code in react-native or in browser. Nowhere is this dependency made explicit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants