fail fast in validator cannot be found

Author: randy-cro

integration_tests/test_staking_cache.py

@@ -34,6 +34,7 @@ def cronos_staking_cache(tmp_path_factory):
         26650,
         Path(__file__).parent / "configs/staking_cache.jsonnet",
     )
+    
 
 def get_delegator_address(cli, account_name):
     """Get delegator address for a specific account."""
@@ -442,14 +443,16 @@ def test_staking_cache_unbonding_validator(cronos_staking_cache):
                 test_val = v
                 break
 
-        if test_val:
-            print(
-                f"Node {node_idx} (cache-size={cache_size}): "
-                f"Status={test_val.get('status', 'unknown')}, "
-                f"Tokens={test_val.get('tokens', '0')}"
-            )
-        else:
-            print(f"Node {node_idx} (cache-size={cache_size}): Validator not found")
+        assert test_val is not None, (
+            f"Node {node_idx} (cache-size={cache_size}): "
+            f"Validator {val_addr} not found in initial status check"
+        )
+
+        print(
+            f"Node {node_idx} (cache-size={cache_size}): "
+            f"Status={test_val.get('status', 'unknown')}, "
+            f"Tokens={test_val.get('tokens', '0')}"
+        )
 
     # Get current self-delegation amount
     delegations = cli.get_delegated_amount(val_account)
@@ -491,21 +494,20 @@ def test_staking_cache_unbonding_validator(cronos_staking_cache):
                     cache_size = [-1, 0, 1, 2, 3][node_idx]
                     validator = node_cli.validator(val_addr)
 
-                    if validator and "validator" in validator:
-                        val_info = validator["validator"]
-                        status = val_info.get("status", "unknown")
-                        tokens = val_info.get("tokens", "0")
-                        jailed = val_info.get("jailed", False)
-                        unbonding_statuses.append(status)
-                        print(
-                            f"Node {node_idx} (cache-size={cache_size}): "
-                            f"Status={status}, Tokens={tokens}, Jailed={jailed}"
-                        )
-                    else:
-                        print(
-                            f"Node {node_idx} (cache-size={cache_size}): "
-                            f"Validator not found"
-                        )
+                    assert validator and "validator" in validator, (
+                        f"Node {node_idx} (cache-size={cache_size}): "
+                        f"Failed to query validator {val_addr} after unbonding"
+                    )
+
+                    val_info = validator["validator"]
+                    status = val_info.get("status", "unknown")
+                    tokens = val_info.get("tokens", "0")
+                    jailed = val_info.get("jailed", False)
+                    unbonding_statuses.append(status)
+                    print(
+                        f"Node {node_idx} (cache-size={cache_size}): "
+                        f"Status={status}, Tokens={tokens}, Jailed={jailed}"
+                    )
 
                 # Assert validator is in BOND_STATUS_UNBONDING on all nodes
                 assert len(set(unbonding_statuses)) == 1, (
@@ -773,13 +775,15 @@ def test_staking_cache_consistency(cronos_staking_cache):
         cache_size = [-1, 0, 1, 2, 3][node_idx]
         validator = node_cli.validator(val_addr)
 
-        if validator and "validator" in validator:
-            val_info = validator["validator"]
-            status = val_info.get("status", "unknown")
-            unbonding_statuses.append(status)
-            print(f"  Node {node_idx} (cache-size={cache_size}): Status={status}")
-        else:
-            print(f"  Node {node_idx} (cache-size={cache_size}): Validator not found")
+        assert validator and "validator" in validator, (
+            f"Node {node_idx} (cache-size={cache_size}): "
+            f"Failed to query validator {val_addr} after unbonding"
+        )
+
+        val_info = validator["validator"]
+        status = val_info.get("status", "unknown")
+        unbonding_statuses.append(status)
+        print(f"  Node {node_idx} (cache-size={cache_size}): Status={status}")
 
     assert (
         len(set(unbonding_statuses)) == 1