Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments missing from consolidated emails #288

Closed
scarroll32 opened this issue Aug 18, 2017 · 7 comments
Closed

Comments missing from consolidated emails #288

scarroll32 opened this issue Aug 18, 2017 · 7 comments

Comments

@scarroll32
Copy link
Contributor

scarroll32 commented Aug 18, 2017

Also add the link to change subscription options.

@marcelsalathe
Copy link

I would also change the submission links - at the moment, I am getting an email that says multiple times "NIPS 2017: Learning to Run by eatnow. " But all the links go to the same page. So perhaps, what I would do instead is to just write:

Submissions Summary
The challenge NIPS 2017: Learning to Run has received 13 new submissions.
The challenge OpenSNP Height Prediction has received 1 new submission.

Then, for the discussion summary, I would do something like this (this is how Basecamp does it):
screen shot 2017-08-19 at 10 54 14 am

@scarroll32
Copy link
Contributor Author

The basecamp approach looks good, but there are a couple of considerations for crowdAI.

  • It is possible to print the comment content in the email, but the comments are often very long. To truncate them is also possible, but as they are rendered html generated from markdown, truncating would require either finding the body text within a markdown tag, then re-rendering, or parsing the rendered html to remove some content but still keep a valid closing tag. Neither approach would be trivial to implement.

  • An alternative would be to simple print the comment topic, which is plain text. Code could be implemented to summarise all comments against the topic, with the comment topic and participant names as links, as below:

Comments Summary

Comments were made on the how to manage free text quiz submissions? discussion topic by bill, user99 and another user.

A Comment was made on the a different topic discussion topic by bill.

@marcelsalathe
Copy link

marcelsalathe commented Aug 19, 2017 via email

@scarroll32
Copy link
Contributor Author

I believe this approach will lead to very long emails, as well as broken-looking text when mixed formatting elements are used. But OK, will implement.

@scarroll32 scarroll32 self-assigned this Aug 21, 2017
@marcelsalathe
Copy link

I think if we limit ourselves to less text than the Basecamp example, we should be fine. How about we implement a first version and then review before pushing live?

@scarroll32
Copy link
Contributor Author

scarroll32 commented Aug 21, 2017

Yes no problem. (Need to also add the "change email settings" link)

@marcelsalathe marcelsalathe added this to the 2.1 milestone Sep 2, 2017
@scarroll32
Copy link
Contributor Author

Implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants