Add note for potential inconsistency in resource matching logic

jcogilvie · jcogilvie · commit ab2e4c8ac3d0 · 2025-09-30T11:47:09.000-04:00
Signed-off-by: Jonathan Ogilvie &lt;jonathan.ogilvie@sumologic.com&gt;
diff --git a/cmd/diff/diffprocessor/resource_manager.go b/cmd/diff/diffprocessor/resource_manager.go
@@ -290,6 +290,9 @@ func (m *DefaultResourceManager) findMatchingResource(
 			continue
 		}
 
+		// TODO:  is this logic correct?  we should definitely match composition-resource-name, even if the generateName
+		// doesn't match.  maybe as a fallback if we don't have the annotation?
+
 		// If we have a generateName, verify the match has the right prefix
 		if generateName != "" {
 			resName := res.GetName()

Original file line number	Diff line number	Diff line change
`@@ -290,6 +290,9 @@ func (m *DefaultResourceManager) findMatchingResource(`
`290`	`290`	`continue`
`291`	`291`	`}`
`292`	`292`
	`293`	`+ // TODO: is this logic correct? we should definitely match composition-resource-name, even if the generateName`
	`294`	`+ // doesn't match. maybe as a fallback if we don't have the annotation?`
	`295`	`+`
`293`	`296`	`// If we have a generateName, verify the match has the right prefix`
`294`	`297`	`if generateName != "" {`
`295`	`298`	`resName := res.GetName()`