Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EntityID #257

Closed
miketonks opened this issue Jan 31, 2020 · 3 comments
Closed

Add EntityID #257

miketonks opened this issue Jan 31, 2020 · 3 comments

Comments

@miketonks
Copy link
Contributor

We would like to be able to specify the EntityID in the Service Provider, instead of using the Metadata URL.

I found a PR for same issue, although it was closed without comment. #239

I will make a new PR based on this, as I see a few things have changed so it needs updating.

@crewjam
Copy link
Owner

crewjam commented Jan 31, 2020

Sounds good to me. I'm not sure why the author closed it, but it seems like an appropriate change. Thanks!

@miketonks
Copy link
Contributor Author

miketonks commented Feb 3, 2020

Submitted PR: #258

I've handled the fallback to MetadataURL in multiple places, as that seemed the best way to ensure backwards compatibility and not break existing tests.

I've also added a new test for EntityID based on TestCanProduceMetadataNoSigningKey.

Note: this is working for me with Azure AD.

@miketonks
Copy link
Contributor Author

Thanks for accepting the PR, and responding so quickly :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants