Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library broken after cookie changes #137

Closed
jhaynie opened this issue Jan 17, 2018 · 1 comment
Closed

Library broken after cookie changes #137

jhaynie opened this issue Jan 17, 2018 · 1 comment

Comments

@jhaynie
Copy link

jhaynie commented Jan 17, 2018

#133 broke some of our code since we depended on the ability to set a custom cookie name for the token which was exposed before. it appears now you can't (easily) set the cookie.

looking through the changes, i guess i would now need to implement the new interfaces if i wanted my set my own cookie name?

which brings up another issue, would it be possible to semver this project to prevent major changes like this from breaking? (i see that you have a 1.0 and 2.0 release but they are old. more recent release with consistent semver would be awesome!)

@evt
Copy link

evt commented Jan 29, 2018

+1

@jhaynie jhaynie closed this as completed Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants