Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce front-end tasks #7

Open
nmalecki opened this issue Sep 16, 2022 · 1 comment
Open

Introduce front-end tasks #7

nmalecki opened this issue Sep 16, 2022 · 1 comment

Comments

@nmalecki
Copy link
Collaborator

nmalecki commented Sep 16, 2022

We should introduce some tasks to handle front-end code quality - for example - eslint.
In this issue, we can collect the ideas for what tasks we can implement into the tool.
Existing tasks in the GrumPHP https://github.com/phpro/grumphp/blob/master/doc/tasks.md - it means that we can easily implement them. If you have another idea - it's also good, this tool is easily extensibility so we can create and add our own task :)

@kwolny-creatuity
Copy link

We have some problems with code formatting on frontend. Usually because we use only code formatting provided by our IDE's (some of us use VS Code, some PHPStorm). We should implement a tool which will check our code before commiting and which will be independent of our IDE's.
I made some research and I think that good solution would be prettier used with git hooks (pre-commit git hook)
this is an article that I found:
https://deepinder.me/format-code-style-with-prettier-in-react-on-git-commit
I didn't tested it yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants