-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add The Greats as a search engine #151
Conversation
@PreciousOritsedere please finish completing the checklist as relevant ❤️ |
I’ve done so now |
@PreciousOritsedere PR is out of date with main |
Can you guide me on how to fix this please |
@PreciousOritsedere sure, I can try. Looking at how you are doing things, what you would likely need to do on your local setup is: in your commandline while working in your local codebase,
then, then you can do a git push to your forked repo, and it should reflect here. I should note for others, that it's usually a good idea to work in a branch that's not main and if that's what someone is doing the instructions above will need to differ. |
Okay I’ll try this. Thank you |
@possumbilities i have carried out your instructions. I think it’s up to date now |
You'll need to have added and verified your website in Google Search Console to do this. |
@PreciousOritsedere Thank you for all your work here, but since the Greats currently conflicts with the limits of the current CC Search Portal UX there's no reliable way to merge this, but that's likely to be possible down the line when the UX improves. ❤️ |
Okay. Thank you |
Fixes
Fixes #145 by @PreciousOritsedere
Description
This PR adds "The Greats" as an additional search engine
Technical details
Tests
Screenshots
Checklist
Update index.md
).main
ormaster
).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin