Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add The Greats as a search engine #151

Closed

Conversation

PreciousOritsedere
Copy link
Contributor

@PreciousOritsedere PreciousOritsedere commented Oct 26, 2022

Fixes

Fixes #145 by @PreciousOritsedere

Description

This PR adds "The Greats" as an additional search engine
Screenshot (86)

Technical details

Tests

Screenshots

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@PreciousOritsedere PreciousOritsedere requested review from a team and possumbilities and removed request for a team October 26, 2022 17:36
@possumbilities possumbilities changed the title Added The Greats as a search engine Add The Greats as a search engine Oct 26, 2022
@possumbilities
Copy link
Contributor

@PreciousOritsedere please finish completing the checklist as relevant ❤️

@PreciousOritsedere
Copy link
Contributor Author

@PreciousOritsedere please finish completing the checklist as relevant ❤️

I’ve done so now

@possumbilities
Copy link
Contributor

@PreciousOritsedere PR is out of date with main

@PreciousOritsedere
Copy link
Contributor Author

@PreciousOritsedere PR is out of date with main

Can you guide me on how to fix this please

@possumbilities
Copy link
Contributor

@PreciousOritsedere sure, I can try. Looking at how you are doing things, what you would likely need to do on your local setup is:

in your commandline while working in your local codebase,

git fetch origin

then,
git merge origin/main

then you can do a git push to your forked repo, and it should reflect here.

I should note for others, that it's usually a good idea to work in a branch that's not main and if that's what someone is doing the instructions above will need to differ.

@PreciousOritsedere
Copy link
Contributor Author

@PreciousOritsedere sure, I can try. Looking at how you are doing things, what you would likely need to do on your local setup is:

in your commandline while working in your local codebase,

git fetch origin

then, git merge origin/main

then you can do a git push to your forked repo, and it should reflect here.

I should note for others, that it's usually a good idea to work in a branch that's not main and if that's what someone is doing the instructions above will need to differ.

Okay I’ll try this. Thank you

@PreciousOritsedere
Copy link
Contributor Author

@possumbilities i have carried out your instructions. I think it’s up to date now

@SilasEze
Copy link

You'll need to have added and verified your website in Google Search Console to do this.

@possumbilities
Copy link
Contributor

@PreciousOritsedere Thank you for all your work here, but since the Greats currently conflicts with the limits of the current CC Search Portal UX there's no reliable way to merge this, but that's likely to be possible down the line when the UX improves. ❤️

@PreciousOritsedere
Copy link
Contributor Author

@PreciousOritsedere Thank you for all your work here, but since the Greats currently conflicts with the limits of the current CC Search Portal UX there's no reliable way to merge this, but that's likely to be possible down the line when the UX improves. ❤️

Okay. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add 'The Greats' as an external source
3 participants