Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create troubleshooting_known_issues_with_docker_on_windows.md #157

Closed
wants to merge 2 commits into from
Closed

Create troubleshooting_known_issues_with_docker_on_windows.md #157

wants to merge 2 commits into from

Conversation

Marshalng
Copy link
Contributor

@Marshalng Marshalng commented Oct 28, 2022 •
edited
Loading

docker_windows_troubleshooting.md

Fixes

Fixes #141 by @Marshalng

Description

This guide troubleshoots known Dockers issues and those raised in our Slack channels

Technical details

Tests

Screenshots

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Marshalng Marshalng requested review from a team and possumbilities and removed request for a team October 28, 2022 22:36
@Marshalng Marshalng mentioned this pull request Oct 28, 2022
Open
1 task
@possumbilities
Copy link
Contributor

@Marshalng let's try to shorten the title a bit for starters to docker_windows_troubleshooting.md, unless you've got a better name in mind to suggest? Since there are no specific instructions here for VS Code intersecting with the project I think it best to drop mention of it in the README, and drop it from the title.

Item 2 in the guide is not directly related to Windows and Docker, it's an error that can occur through the use of Docker on any platform and would be better suited in another guide that's for docker specifically (and probably on the Open Source website instead).

After reading through everything written here, the overall guide reads as generally relavant to Docker and Windows, but has nothing specifically to do with this project. General guides should be on the Open Source website:

Unless you can outline items in this PR that are specific to this repo and its intersection with various technologies, it might be better for this work to move to an Issue on the creativecomms.github.io-source repository.

@Marshalng Marshalng changed the title Create troubleshooting_known_issues_with_docker_and_vs_code_ on_windows.md Create troubleshooting_known_issues_with_docker_on_windows.md Oct 31, 2022
@Marshalng
Update and rename troubleshooting_known_issues_with_docker_and_vs_cod…
05068c5 
…e_ on_windows.md to docker_windows_troubleshooting.md
@Marshalng
Copy link
Contributor Author

Very thoughtful observations @possumbilities the name has been changed as suggested and all occurrences of VS Code removed. I also agree with you on moving it to General Guides.

@possumbilities
Copy link
Contributor

@Marshalng I'd suggest you move it to an RFC on the General Guides if you aren't going to expand to anything specific to this project. If you do come up with specific things for a guide like this feel free to submit a new PR :)

Thanks so much for your work thus far! ❤️

@possumbilities possumbilities self-assigned this Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@possumbilities possumbilities Awaiting requested review from possumbilities

Assignees

@possumbilities possumbilities

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Guide: Troubleshooting known Issues with Docker on Windows
2 participants
@Marshalng @possumbilities