Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] CSS Link Tag Does Not Follow Vocabulary Documentation #220

Open
1 task
SisiVero opened this issue Oct 14, 2024 · 5 comments · Fixed by #224 or #229
Open
1 task

[Bug] CSS Link Tag Does Not Follow Vocabulary Documentation #220

SisiVero opened this issue Oct 14, 2024 · 5 comments · Fixed by #224 or #229
Assignees
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🏁 status: ready for work Ready for work

Comments

@SisiVero
Copy link

SisiVero commented Oct 14, 2024

Description

The <link> tag for the CSS file is missing the media attribute, which is required for proper HTML semantics.
And this does not follow the vocabulary docs. In the vocabulary docs, link tag for stylesheets must have the media="all".

Reproduction

  1. Clone the repo and go to base.html in scholarship folder
  2. Observe that the <link> tag for the CSS file does not include a media attribute:
  3. See error.

Expectation

The link tag for stylesheet should have the media="all" as stated in Vocabulary documentation.

Additional context

Resolution

  • I would be interested in resolving this bug.
@SisiVero SisiVero added 💻 aspect: code Concerns the software code in the repository 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents labels Oct 14, 2024
@TimidRobot TimidRobot added help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🏁 status: ready for work Ready for work and removed 🟧 priority: high Stalls work on the project or its dependents 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Oct 14, 2024
@bhekidaweti
Copy link
Contributor

Hello, I am an Outreachy applicant, I would like to work on this.

@Queen-codes
Copy link
Contributor

Hello, I am an Outreachy applicant, I would like to work on this.

hi @bhekidaweti , I hope you're doing okay. You can indicate your interest in an issue by opening a pull request with your own solution for the issue. However, any issue that you open a PR for must have the ready for work label. I hope this helps clarify things for you and I hope you have a good time contributing to this project.

@TimidRobot
Copy link
Member

Please see Contribution Guidelines — Creative Commons Open Source for how we manage issues and pull requests (PRs).

We generally don't assign issues prior to resolution. Instead of asking for issues to be assigned, do the work and submit a PR. Even if multiple people submit PRs for the same issue, multiple ideas and implementations strengthen the final product.

For work program applicants, each can all list their own PRs on their application. It is the quality of work that is important, not whether it is merged.

@bhekidaweti
Copy link
Contributor

Thanks, I fully understand now.

@TimidRobot
Copy link
Member

@babyteega please add a comment to this issue so I can assign it to you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🏁 status: ready for work Ready for work
Projects
Archived in project
Archived in project
4 participants