Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

responsive: true only effects width #34

Closed
jonathan-fielding opened this issue Jan 28, 2014 · 10 comments
Closed

responsive: true only effects width #34

jonathan-fielding opened this issue Jan 28, 2014 · 10 comments
Milestone

Comments

@jonathan-fielding
Copy link

the height should automatically be calculated and scale with the width

@creativeaura
Copy link
Owner

Correct, I will look at this issue.

@creativeaura
Copy link
Owner

@jonathan-fielding Can I use your SimpleStateManager to change the height on different breakpoints ?

@jonathan-fielding
Copy link
Author

I would advise against it as jquery plugins should only have the dependency of jQuery, not on 2 libraries.

@jonathan-fielding
Copy link
Author

what you likely need to do is take the original specified width and height, calculate the aspect ratio and then as the width changes the height would need to change inline

@creativeaura creativeaura modified the milestone: Version 2.0.0 Jul 23, 2014
@misterboe
Copy link

the problem could be solved if you would get the hight of the current-image and set this as hight of ". threesixty"

@husa
Copy link

husa commented Aug 12, 2014

This is high priority for me either

@creativeaura
Copy link
Owner

Releasing V2 next week and this bug will be fixed

@husa
Copy link

husa commented Aug 12, 2014

great!

@kacperpl1
Copy link

Is this v2.0 coming soon? I'm really looking forward responsive height bug fix.

@creativeaura
Copy link
Owner

v2.0.0 is available now and responsive height is fixed in latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants