Clean up the rpc.serverInfo implementation. #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
creachadair
commented
Mar 15, 2023
creachadair
commented
- Remove the RPCServerInfo client helper, it was unused outside tests.
- Remove the methodFunc wrapper type, it is no longer necessary.
- Fix up tests.
- Remove the RPCServerInfo client helper, it was unused outside tests. - Remove the methodFunc wrapper type, it is no longer necessary. - Fix up tests. Updates #46.
creachadair
force-pushed
the
mjf/cleanup-special
branch
from
86c5f92 to
82b5150
Compare
creachadair
added a commit
that referenced
this pull request
Mar 19, 2023
Documentation: - 8628a62 server: clean up an obsolete comment - 628f1a8 handler: fix a comment typo - 9449abd handler: remove implementation details from docs (#96) - 370c1eb Clean up package doc. - cf1bb22 Clarify that Stop cancels running call handlers. Cleanup: - ce007de Clean up the rpc.serverInfo implementation. (#94) - 2670c9f Construct the internal queue by value. Breaking changes: - ef7b642 Collapse the code package into jrpc2. (#97)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.