Remove support for parameter injection. #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature adds a lot of code for relatively little benefit. In practice, a service can achieve the same effect by embedding common headers in its argument types, which gives more control to both client and server without the overhead of an additional encoding step. - Remove the EncodeContext and DecodeContext options. - Remove the plumbing to encode (client) and decode (server) contexts. - Remove the jctx package. - Update usage in the jcall command-line tool. - Clean up tests.
creachadair
added a commit
that referenced
this pull request
May 13, 2022
After #82 removed support for parameter injection, support for plumbing the HTTP request context into the client became pointless. This change removes the vestiges of it, which can no longer serve any useful purpose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature adds a lot of code for relatively little benefit. In practice, a
service can achieve the same effect by embedding common headers in its argument
types, which gives more control to both client and server without the overhead
of an additional encoding step.