channel: Remove the Varint framing.

#46 (comment)
creachadair · May 10, 2021 · 70cc886 · 70cc886
1 parent cc566c1
commit 70cc886
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 72 deletions.
diff --git a/channel/bench_test.go b/channel/bench_test.go
@@ -43,7 +43,6 @@ func BenchmarkFramingCost(b *testing.B) {
 		{"LSP", channel.LSP},
 		{"NUL", channel.Split('\x00')},
 		{"RawJSON", channel.RawJSON},
-		{"Varint", channel.Varint},
 	}
 
 	msg, err := json.Marshal(benchMessage)

diff --git a/channel/channel_test.go b/channel/channel_test.go
@@ -84,7 +84,6 @@ var tests = []struct {
 	{"RS", Split('\x1e')},
 	{"RawJSON", RawJSON},
 	{"StrictHeader", StrictHeader("text/plain")},
-	{"Varint", Varint},
 }
 
 // N.B. the messages in this list must be valid JSON, since the RawJSON framing

diff --git a/channel/chanutil/chanutil.go b/channel/chanutil/chanutil.go
@@ -16,7 +16,6 @@ import (
 //    line     -- corresponds to channel.Line
 //    lsp      -- corresponds to channel.LSP
 //    raw      -- corresponds to channel.RawJSON
-//    varint   -- corresponds to channel.Varint
 //
 func Framing(name string) channel.Framing {
 	if t := strings.TrimPrefix(name, "header:"); t != name {
@@ -29,8 +28,7 @@ func Framing(name string) channel.Framing {
 }
 
 var framings = map[string]channel.Framing{
-	"line":   channel.Line,
-	"lsp":    channel.LSP,
-	"raw":    channel.RawJSON,
-	"varint": channel.Varint,
+	"line": channel.Line,
+	"lsp":  channel.LSP,
+	"raw":  channel.RawJSON,
 }
diff --git a/channel/varint.go b/channel/varint.go
diff --git a/server/loop_test.go b/server/loop_test.go
@@ -13,7 +13,7 @@ import (
 	"github.com/creachadair/jrpc2/handler"
 )
 
-var newChan = channel.Varint
+var newChan = channel.Line
 
 // A static test service that returns the same thing each time.
 var testService = NewStatic(handler.Map{