From 5ac86374035be1bc612ed8e403acd8fa443b1b46 Mon Sep 17 00:00:00 2001 From: "M. J. Fromberger" Date: Sat, 15 Jan 2022 11:14:02 -0800 Subject: [PATCH] jhttp: set headers before calling WriteHeader This was actually safe as written, but the API does not promise to honour headers set after the code is marked. --- jhttp/getter.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jhttp/getter.go b/jhttp/getter.go index 1c9c77d..eac81a2 100644 --- a/jhttp/getter.go +++ b/jhttp/getter.go @@ -150,8 +150,8 @@ func writeJSON(w http.ResponseWriter, code int, obj interface{}) { fmt.Fprintln(w, err.Error()) return } - w.WriteHeader(code) w.Header().Set("Content-Type", "application/json") w.Header().Set("Content-Length", strconv.Itoa(len(bits))) + w.WriteHeader(code) w.Write(bits) }