[BUG] Default settings are not treated as config settings

[jsliacan]

General information

• OS: Linux
• Hypervisor: KVM

CRC version

CodeReady Containers version: 1.26.0+8f6f946f
OpenShift version: 4.7.7 (not embedded in executable)

CRC config

Steps to reproduce

1. crc start --disk-size 40
2. crc stop && crc config unset disk-size (if it was set)
3. crc start (should fall back on default 31G & complain that shrink not supported)

Note: if the default value of 31G is explicitly set in config, CRC complains at start as it should. Only implicit default results in the above.

Expected

Specified disk size is less than current one, not allowed. (or something similar)

Actual

Starts without warnings/info/error but ignores the default setting and keeps previous 40G.

[gbraad]

crc start --disk-size 40
crc stop && crc config unset disk-size (if it was set)
crc start (should fall back on default 31G & complain that shrink not supported)

I believe the config option is only considered at the moment the VM is created; meaning, when not existing and started.

However, we never scale the disk-size BACK to a lower disk-size. So if started with 40G you can't resize to 39G. This is to ensure we do not need to test for the internal disk use.

---

I would suggest to bring this up as a discussion and create/refine the user story for #2243 and #2261. See discussion #2317

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.