Skip to content

Conversation

@matkuliak
Copy link
Contributor

@matkuliak matkuliak commented Apr 16, 2024

Summary of the changes / Why this is an improvement

We're moving the tutorials from Cloud here

References

@matkuliak matkuliak requested a review from amotl April 16, 2024 03:28
Copy link
Member

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for carrying this over. I've added a few suggestions about »naming things«.

@matkuliak
Copy link
Contributor Author

I've added a few suggestions about »naming things«.

Edited, thank you for good suggestions.

Copy link
Member

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, approving. Currently, it does not make sense to employ the redirects, because GH-53 will change the structure: Both "document" and "search" will go to the "Features" section, so redirects would need to be changed for another time.

I think I wanted to make you aware of this, so you could have derived your feature branch directly from amo/timeseries-more. Apologies if I missed that, so please go ahead and just merge, in order to let me do the refactoring afterwards.

@matkuliak
Copy link
Contributor Author

Ah, I forgot about that one.
Your #53 was started before this, please go ahead. Happy to wait and shuffle this around when it fits

@matkuliak matkuliak merged commit 8686293 into main May 2, 2024
@matkuliak matkuliak deleted the mm/move-tutorials branch May 2, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants