Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Systemessages translation keys/rules less strict #3888

Closed
Anubarak opened this issue Feb 22, 2019 · 1 comment
Closed

Make Systemessages translation keys/rules less strict #3888

Anubarak opened this issue Feb 22, 2019 · 1 comment

Comments

@Anubarak
Copy link
Contributor

Description

Currently when sending a Systemmessage to a craft\elements\User passed via message::setTo there must be an exact match of the prefered language and the site language. So when a User submits en-US in his/her preferences but the site is en or en-GB the user won't receive the translated message but the default system message. It would be good to match en with en-XX if no exact match was found.

Steps to reproduce

  1. Create a user with en-US language
  2. Change the content of a Systemmessage in a site with en-GB
  3. Send a mail to this user and see it uses the default message
@Anubarak Anubarak changed the title Make Systemessages translation rules less strict Make Systemessages translation keys/rules less strict Feb 22, 2019
@brandonkelly
Copy link
Member

All set for the next release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brandonkelly @Anubarak