Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x]: Action buttons in Matrix blocks have weird placement #15965

Closed
shoored opened this issue Oct 25, 2024 · 5 comments
Closed

[4.x]: Action buttons in Matrix blocks have weird placement #15965

shoored opened this issue Oct 25, 2024 · 5 comments
Assignees

Comments

@shoored
Copy link

shoored commented Oct 25, 2024

What happened?

Description

Action buttons in Matrix blocks have weird placement

Steps to reproduce

  1. Open an entry with a Matrix field and some blocks

Expected behavior

Buttons are nicely aligned in the blocks' toolbar

Actual behavior

The inherited min-height on the .btn class gives the .settings button a height of 34px instead of the defined 20px.
Also it seems the .disabled class is no longer present on disabled blocks, which the MatrixMate plugin relies on for spacing.

Image

Craft CMS version

4.12.8

PHP version

8.2

@shoored shoored changed the title [4.x]: [4.x]: Action buttons in Matrix blocks have weird placement Oct 28, 2024
@i-just i-just self-assigned this Oct 28, 2024
@i-just
Copy link
Contributor

i-just commented Oct 28, 2024

Hi, thanks for reporting! I raised a PR for the height/placement issue.

As for the .disabled class, as of v4.9.4, the .matrixblock uses the .disabled-entry class to indicate disabled blocks.

@shoored
Copy link
Author

shoored commented Oct 28, 2024

Thanks @i-just for the quick response!
Yeah the .disabled class "bug" is a MatrixMate thing. Strange that I never noticed it before.

@mmikkel
Copy link
Contributor

mmikkel commented Oct 28, 2024

@shoored I just tagged MatrixMate v. 2.2.2 with a fix for the .disabled bug 🙂

@shoored
Copy link
Author

shoored commented Oct 30, 2024

@mmikkel Oh how great, thanks! :)

@brandonkelly
Copy link
Member

Craft 4.12.9 is out with that fix for the Matrix button styling. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants