Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x]: Slideout of Filesystems cannot be dismissed and prompts to save changes #13707

Closed
engram-design opened this issue Sep 17, 2023 · 4 comments
Assignees

Comments

@engram-design
Copy link
Contributor

What happened?

Description

There's two issues here with editing a volume and the filesystem related to it, and both are about the slide-out functionality. It's probably going to affect other things that use the slide-out too (I initially was trying to solve this for Hyper which uses the slide-out to edit fields).

Firstly, when you go to create a new filesystem, and make no changes, it prompts you with the usual unload warning like you have made a change, but you haven't. It probably shouldn't show this unless you've made a change?

https://share.cleanshot.com/8rjFY9qJ

Secondly, I can't seem to actually dismiss the slide-out anymore. After clicking the Cancel/Okay button on the browser unload prompt, I then try to click anywhere else on the page, and it just re-opens the slide-out.

https://share.cleanshot.com/zGWksssv

Craft CMS version

4.5.5

PHP version

No response

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

@i-just
Copy link
Contributor

i-just commented Sep 19, 2023

Hi, thanks for reporting! I raised a PR to adjust this.

@brandonkelly
Copy link
Member

Fixed for the next release via #13716.

@engram-design
Copy link
Contributor Author

Thanks as always!

@brandonkelly
Copy link
Member

Craft 4.5.6 is out now with that fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants