Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x]: Matrix field is incorrectly labelled as translatable with custom propagation key format #13329

Closed
MoritzLost opened this issue Jun 16, 2023 · 2 comments
Assignees

Comments

@MoritzLost
Copy link
Contributor

MoritzLost commented Jun 16, 2023

What happened?

Description

I'm seeing an issue where a matrix field gets the little icon to indicate a translatable field (This field is translatable) even though it isn't translatable in that context.

Screenshot 2023-06-16 at 12 43 06

Steps to reproduce

  1. Create a Matrix Field, set the Propagation Method to Custom… and use the following template:
    {{ section.type == 'single' ? site.handle }}
  2. Add the Matrix Field to one Single section and one Channel or Structure section.
  3. Open the entry form for an entry in both sections. The field will be labelled as translatable in both, even though it should only do so for the entry in the Single section.

Expected behavior

We want the matrix blocks to propagate between sites in Structure or Channel sections, but we don't want them to propagate in Single sections. The field should only be marked as translatable on entries in Single sections.

Actual behavior

The actual propagation behavior is correct (blocks are propagated between sites on Structure and Channel sections, but not on Single sections). However, the field is labelled as translatable in Structure and Channel sections, even though it isn't translatable in those contexts.

We use the same template for the Translation Key Format for regular text fields, this works correctly and the icon only shows up in the appropriate context.

Craft CMS version

4.4.10.1

PHP version

8.2

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

No response

@i-just
Copy link
Contributor

i-just commented Jun 19, 2023

Hi, thanks for reporting! I raised a PR.

@brandonkelly
Copy link
Member

Craft 4.4.15 is out with a fix for this. Thanks again for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants