Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x]: editable table - select column type does not show optgroups text when adding the new row #13298

Closed
piotrpog opened this issue Jun 8, 2023 · 5 comments
Assignees

Comments

@piotrpog
Copy link

piotrpog commented Jun 8, 2023

What happened?

Steps to reproduce

  • Add editable table widget to control panel page
  • Widget must have select type column and select data must have optgroups
  • When adding the new row, optgroups are without text. If widget is initialized with rows already present, optgroups in these rows show normally.

Craft CMS version

4.4.13

PHP version

8.1

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

@i-just
Copy link
Contributor

i-just commented Jun 9, 2023

@piotrpog I think I’m missing something here. Could you please provide a bit more info on this one? Are you referring to the native Table field type or something else?

@piotrpog
Copy link
Author

piotrpog commented Jun 9, 2023

@i-just
I am refering to twig macro used by plugin developers to create admin pages.
https://github.com/craftcms/cms/blob/develop/src/templates/_includes/forms/editableTable.twig

@i-just
Copy link
Contributor

i-just commented Jun 9, 2023

Perfect, thank you!

@i-just
Copy link
Contributor

i-just commented Jun 9, 2023

I’ve tracked it down. Thanks for reporting! PR submitted.

@brandonkelly
Copy link
Member

Craft 4.4.14 is out with the fix for this. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants