[4.4]: Customise Sources Modal loses headings and litters project config

[MattWilcox]

What happened?

Description

If you make a new Heading in the Customise Sources modal, but there are no Sources placed beneath it, you click "save" and nothing seems to have happened.

Going back into the Customise Sources reveals that the heading does not exist there.

Looking into the Project config, there are details in there for it.

1. You can end up with a lot of headings in proj conf that are totally inaccessible in the CMS
2. Explicitly creating a heading and having it not save feels like a bug
3. The same "heading tossed to the ether" happens if you ever move a heading to the bottom ... which is the default placement!

While I understand the reasoning that headings without content beneath them should not be visible in the main UI; they should still appear in the Customise Sources modal. They do not.

Saving this seems to result in nothing happening...

This is the result (though I understand why, it's "weird" behaviour)

But the heading should be here when you go to edit sources again, and it isn't.

Craft CMS version

4.4.0

PHP version

8.1

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

No response

[i-just]

Hi, thanks for reporting. I created a PR for this.

[brandonkelly]

Craft 4.4.1 is out now with the fix!