Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.3.0]: Entry source headings not being hidden when they should #12193

Closed
AndrewMac opened this issue Oct 26, 2022 · 2 comments
Closed

[4.3.0]: Entry source headings not being hidden when they should #12193

AndrewMac opened this issue Oct 26, 2022 · 2 comments
Assignees

Comments

@AndrewMac
Copy link

AndrewMac commented Oct 26, 2022

What happened?

Description

My Craft installation has multiple sites with a number of sections that are available only to certain sites. In the "Entries" view, the entry sources are grouped under different headings. Before the just-released 4.3.0 version, if all the entry sources in a group were disabled (because they were not required for that site), the heading was hidden as well. In 4.3.0, though, the HTML has been changed (in a better way, actually!) but the heading now shows even if all the sources are correctly hidden.

The result is that I now see a whole bunch of headings that used to be hidden.

Basically, it looks like the heading is not picking up the "hidden" class, as you will see in the code I will post below.

Old behaviour

<li class="heading hidden>…</li>
<li class="hidden">…</li>
<li class="hidden">…</li>

New improved behaviour

<li class="heading"> <!-- should also have picked up the "hidden" class" -->
    <span>…</span>
    <ul>
        <li class="hidden">…</li>
        <li class="hidden">…</li>
    </ul>
</li>

Craft CMS version

4.3.0 Pro

PHP version

No response

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

@AndrewMac AndrewMac changed the title [4.x]: Entry source headings not being hidden when they should [4.3.0]: Entry source headings not being hidden when they should Oct 26, 2022
@brandonkelly brandonkelly self-assigned this Oct 26, 2022
@brandonkelly
Copy link
Member

Thanks for reporting that! Fixed for the next release.

@brandonkelly
Copy link
Member

Craft 4.3.1 is out with the fix for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants