Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x]: Command-S opens save webpage dialog instead of saving entry if a menu button is focused #11919

Closed
ttempleton opened this issue Sep 12, 2022 · 1 comment
Assignees

Comments

@ttempleton
Copy link

What happened?

Description

When editing an entry and a menu button is focused, such as the ones for entry save options or changing sites/revisions, pressing command-S to save the entry instead opens the browser's save webpage dialog.

I was able to reproduce this on Craft 4.2.3 using Chrome 105.0.5195.102, Firefox 105.0b9, and Safari 15.6.1. On Craft 3.7 it works as expected.

Steps to reproduce

  1. Edit an entry
  2. Click on the save options menu button
  3. (Optionally) click somewhere else on the page to close the menu
  4. Press Command-S

Expected behavior

That the above steps would save the entry.

Actual behavior

The above steps open the browser's save webpage dialog.

Craft CMS version

4.2.3

PHP version

8.1.10

Operating system and version

macOS Monterey 12.5.1

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

None

@brandonkelly
Copy link
Member

Thanks for reporting that! We just tagged Craft 4.2.4 with a fix for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants