Merge pull request #16965 from craftcms/bugfix/16953-intl-timezones-and-old-dates

allow for dates to be formatted without IntlDateFormatter

Author: brandonkelly

CHANGELOG.md

@@ -7,6 +7,7 @@
 - Fixed a bug where relations weren’t getting saved for new elements, if the element was created with `Craft::createObject()` with its relation field data included in the passed-in config. ([#16942](https://github.com/craftcms/cms/pull/16942))
 - Fixed a bug where relational fields with a “Related To” rule on their selectable elements condition weren’t making all expected elements selectable. ([#16945](https://github.com/craftcms/cms/issues/16945))
 - Fixed a bug where some subdivisions weren’t available when creating addresses. ([#16951](https://github.com/craftcms/cms/issues/16951))
+- Fixed a bug where some older dates could be formatted incorrectly. ([#16953](https://github.com/craftcms/cms/issues/16953))
 
 ## 4.14.11.1 - 2025-03-19
 

src/i18n/Formatter.php

@@ -11,9 +11,13 @@
 use craft\helpers\DateTimeHelper;
 use DateTime;
 use DateTimeZone;
+use Exception;
+use IntlTimeZone;
 use NumberFormatter;
+use Yii;
 use yii\base\InvalidArgumentException;
 use yii\base\InvalidConfigException;
+use yii\helpers\FormatConverter;
 
 /**
  * @inheritdoc
@@ -80,13 +84,64 @@ public function asDate($value, $format = null): string
             $format = $this->dateTimeFormats[$format]['date'];
         }
 
+        // https://github.com/craftcms/cms/issues/16953
+        $dateFormattedWithoutIntl = $this->formatDateWithoutIntl($value, $format);
+        if ($dateFormattedWithoutIntl !== null) {
+            return $dateFormattedWithoutIntl;
+        }
+
         if (strncmp($format, 'php:', 4) === 0) {
             return $this->_formatDateTimeValueWithPhpFormat($value, substr($format, 4), 'date');
         }
 
         return parent::asDate($value, $format);
     }
 
+    /**
+     * Checks if the date should be formatted without the help of intl.
+     * This is needed for some "old" dates, like dates from 19th century from Europe/Amsterdam timezone
+     *
+     * @param int|string|DateTime $value
+     * @param string|null $format
+     * @return string|null
+     * @throws Exception
+     */
+    private function formatDateWithoutIntl(int|string|DateTime $value, ?string $format): ?string
+    {
+        // see https://github.com/craftcms/cms/issues/16953 for more details on why this method was added
+
+        if (!$value instanceof DateTime || !extension_loaded('intl')) {
+            return null;
+        }
+
+        $intlTimeZone = IntlTimeZone::fromDateTimeZone($value->getTimezone());
+        $intlTimeZone->getOffset($value->getTimestamp(), true, $o1, $o2);
+        $intlTimeZone->getOffset($value->getTimestamp(), false, $o3, $o4);
+
+        // get PHP DateTime offset for this date
+        $phpOffset = $value->getTimezone()->getOffset($value);
+        // get DST offset that intl time zone would use (divided by 1000, b/c different units)
+        $dstIntlOffset = ($intlTimeZone->getRawOffset() + $intlTimeZone->getDSTSavings()) / 1000;
+        // get raw offset that intl time zone would use (divided by 1000, b/c different units)
+        $rawIntlOffset = $intlTimeZone->getRawOffset() / 1000;
+
+        // compare the php and intl offsets
+        // if either are the same, we're good to proceed with the intl approach, as we used to;
+        // but if they're both different, we should use PHP to format the date
+        if ($phpOffset === $dstIntlOffset || $phpOffset === $rawIntlOffset) {
+            return null;
+        }
+
+        // copied from yii\i18n\Formatter::formatDateTimeValue()
+        if (strncmp($format, 'php:', 4) === 0) {
+            $format = substr($format, 4);
+        } else {
+            $format = FormatConverter::convertDateIcuToPhp($format, 'date', Yii::$app->language);
+        }
+
+        return $value->format($format);
+    }
+
     /**
      * @inheritdoc
      * @param int|string|DateTime $value