Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x]: When a CKEditor field contains a <br> tag it gets marked as changed on focus #85

Closed
thupsi opened this issue Apr 24, 2023 · 5 comments
Assignees
Labels

Comments

@thupsi
Copy link

thupsi commented Apr 24, 2023

What happened?

Description

When a CKEditor field contains a <br> tag it gets marked as changed on focus.

Steps to reproduce

  1. Create a CKEditor field and add it to an entry type.
  2. Go to an entry and type some text in the field, including a <br> tag (eg with SHIFT + ENTER).
  3. Save the entry.
  4. Click in the field, withour typing anything.

Expected behavior

The field should not get marked as changed until the editor actually types something.

Actual behavior

The field gets marked as changed.

Craft CMS version

Craft CMS 4.4.7.1

PHP version

No response

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

CKEditor 3.2.0

@thupsi thupsi added the bug label Apr 24, 2023
@thupsi thupsi changed the title [4.x]: When a CKEditor field contains a <br> tag it gets marked as change on focus [4.x]: When a CKEditor field contains a <br> tag it gets marked as changed on focus Apr 24, 2023
@i-just i-just self-assigned this Apr 24, 2023
@i-just
Copy link
Contributor

i-just commented Apr 24, 2023

Hi, thanks for reporting! I have raised a PR in the ckeditor repo for this.

@brandonkelly brandonkelly transferred this issue from craftcms/cms Apr 24, 2023
@brandonkelly
Copy link
Member

Fixed for the next release via #83!

@thupsi
Copy link
Author

thupsi commented Apr 25, 2023

I just discovered that the same thing happens with other tags, like links (copy pasted or inserted via the link button) and non-breaking spaces (eg inserted automaticaly inside a p tag when typing ENTER two consecutive times).

Should I open a separate issue?

@i-just
Copy link
Contributor

i-just commented Apr 26, 2023

Should I open a separate issue?

Yes, please!

@brandonkelly
Copy link
Member

3.3.0 is out with that fix 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants