Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to CKEditor v40 for the multiBlock option #141

Closed
MoritzLost opened this issue Oct 10, 2023 · 6 comments
Closed

Update to CKEditor v40 for the multiBlock option #141

MoritzLost opened this issue Oct 10, 2023 · 6 comments
Assignees
Labels

Comments

@MoritzLost
Copy link
Contributor

Description

We need the multiBlock option to limit author's ability to enter multiple blocks / paragraphs in a list. This is supported in CKEditor 40:

However, the plugin is currently on CKEditor 39.0.2, so we can't use that option.

Bumping the CKEditor version would be greatly appreciated – thanks!

Additional info

  • Craft version: 4.5.6.1
  • PHP version: 8.2
  • Plugins & versions: CKEditor 3.6.0
@MoritzLost MoritzLost added the bug label Oct 10, 2023
@leevigraham
Copy link

This would also cleanup the choice between list types:

image

@i-just
Copy link
Contributor

i-just commented Nov 16, 2023

Hi both! Thanks for the nudge. I raised a PR to update to the latest CKEditor, switch to TodoDocumentList plugin and remove the no longer needed lists v1.

@MoritzLost
Copy link
Contributor Author

༼ つ ◕_◕ ༽つ Summoning @brandonkelly for review :)

@brandonkelly
Copy link
Member

CKEditor 3.7.0 was just released, with CKE 5 41.0.0, plus TodoDocumentList has been pulled in, and List, ListProperties, and TodoList have been removed.

@MoritzLost
Copy link
Contributor Author

MoritzLost commented Feb 5, 2024

@brandonkelly @i-just Thanks! 🚀

Is it normal that the listPlugin key remains in the config object with an empty string value in config/project/ckeditor after saving the CKEditor configs?

Screenshot 2024-02-05 at 15 28 37

@brandonkelly
Copy link
Member

That was overlooked, but I’ve fixed it for the next release (cd196c3).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants