From 15b50fe6dc830d81bb94165d23fb53ccfffa7c94 Mon Sep 17 00:00:00 2001 From: Iwona Just Date: Wed, 4 Jan 2023 14:22:08 +0000 Subject: [PATCH 1/3] fix - CKE dying when e.g. matrix block is dragged --- src/assets/field/dist/init.js | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/assets/field/dist/init.js b/src/assets/field/dist/init.js index 7daccb3..a7af60d 100644 --- a/src/assets/field/dist/init.js +++ b/src/assets/field/dist/init.js @@ -22,6 +22,16 @@ async function initCkeditor(id, init) { Garnish.on(Craft.Preview, 'open close', realInit); Garnish.on(Craft.LivePreview, 'beforeEnter beforeExit', deinit); Garnish.on(Craft.LivePreview, 'enter exit', realInit); + + // https://github.com/craftcms/ckeditor/issues/23 + // for when using "move up" and "move down" menu options + Garnish.on(Garnish.Base, 'beforeMoveUp beforeMoveDown', deinit); + Garnish.on(Garnish.Base, 'moveUp moveDown', realInit); + // for when dragging and dropping + Garnish.on(Garnish.BaseDrag, 'dragStop', null, function() { + deinit(); + realInit(); + }); } else { // CKEditor 5 try { From 8979495cc676c7c427e6647e4c5e1ce55e3da95b Mon Sep 17 00:00:00 2001 From: brandonkelly Date: Wed, 4 Jan 2023 14:21:23 -0800 Subject: [PATCH 2/3] Update events --- src/assets/field/dist/init.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/assets/field/dist/init.js b/src/assets/field/dist/init.js index a7af60d..6b13b98 100644 --- a/src/assets/field/dist/init.js +++ b/src/assets/field/dist/init.js @@ -25,10 +25,10 @@ async function initCkeditor(id, init) { // https://github.com/craftcms/ckeditor/issues/23 // for when using "move up" and "move down" menu options - Garnish.on(Garnish.Base, 'beforeMoveUp beforeMoveDown', deinit); - Garnish.on(Garnish.Base, 'moveUp moveDown', realInit); + Garnish.on(Craft.MatrixInput, 'beforeMoveBlockUp beforeMoveBlockDown', deinit); + Garnish.on(Craft.MatrixInput, 'moveBlockUp moveBlockDown', realInit); // for when dragging and dropping - Garnish.on(Garnish.BaseDrag, 'dragStop', null, function() { + Garnish.on(Craft.MatrixInput, 'blockSortDragStop', null, function() { deinit(); realInit(); }); From e8bcdb31a877f39a36ba7b758d1654a7c92f50ba Mon Sep 17 00:00:00 2001 From: brandonkelly Date: Wed, 4 Jan 2023 14:22:43 -0800 Subject: [PATCH 3/3] Release note [ci skip] --- CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1cae0c9..9514687 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,8 @@ # Release Notes for CKEditor for Craft CMS +## Unreleased +- Fixed a bug where CKEditor 4 stopped working when used within a Matrix block, if the block was moved to a new position. ([#23](https://github.com/craftcms/ckeditor/issues/23)) + ## 1.4.0 - 2022-12-16 - Added RTL language support. ([#33](https://github.com/craftcms/ckeditor/issues/33), [#55](https://github.com/craftcms/ckeditor/pull/55))