Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TotalDenominator and TotalNumerator extensions #602

Open
Capt-Mac opened this issue Nov 27, 2024 · 0 comments
Open

Remove TotalDenominator and TotalNumerator extensions #602

Capt-Mac opened this issue Nov 27, 2024 · 0 comments
Assignees

Comments

@Capt-Mac
Copy link
Contributor

TotalNumerator and TotalDenominator populations were defined to remove ambiguity around what makes up the conceptual Finalized results of Denominator/Numerator after the scoring algorithm logic had been applied.

This mainly was raised over disagreement on if CQL expression results are exposed raw to Measure Report results or if it was meant to only show the end result of how the Measure was scored.

This is removal of Denominator-Exclusion criteria results from Denominator...etc

The end result was that Measure Reports show how the Measure Score was calculated, so Numerator/Denominator for ratio and proportion measures. This means that the need for a separate TotalNumerator and TotalDenominator is not needed and we can simply remove the extensions from the Measure Report results and all classes where it is present.

Scope

  • MeasureScorer should now look for Numerator/Denominator values to make the calculation instead of the extension values.
  • Any code that sets or maintains these populations can be removed
  • Testing classes that have assertions for these values should be deprecated
@lukedegruchy lukedegruchy self-assigned this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants