refactor canonicalization

Always canonicalize on the ID. This is simple,
fast, and always correct. We do it always, when
the corpus is built.

fix #31, fix #36

Author: vinniefalco

Diff for: include/mrdox/meta/Symbols.hpp

@@ -49,7 +49,7 @@ enum class InfoType
     IT_typedef
 };
 
-/** Return true if s0 is less than s1.
+/** Return the result of comparing s0 to s1.
 
     This function returns true if the string
     s0 is less than the string s1. The comparison
@@ -58,7 +58,7 @@ enum class InfoType
     are compared with lowercase letters coming
     before uppercase letters.
 */
-bool
+std::strong_ordering
 compareSymbolNames(
     llvm::StringRef symbolName0,
     llvm::StringRef symbolName1) noexcept;

Diff for: source/lib/Corpus.cpp

@@ -238,12 +238,7 @@ build(
     if(GotFailure)
         return makeErrorString("one or more errors occurred");
 
-    //
-    // Finish up
-    //
-
-    if(! corpus->canonicalize(R))
-        return makeError("canonicalization failed");
+    corpus->canonicalize(R);
 
     return corpus;
 }