fix: change FieldFlags::isNodiscard to FieldFlags::isMaybeUnused

Author: sdkrystian

include/mrdox/Metadata/Field.hpp

@@ -29,7 +29,7 @@ union FieldFlags
 
     // KRYSTIAN FIXME: nodiscard cannot be applied to fields; this should
     // instead be isMaybeUnused. we should also store the spelling
-    BitFlag<0> isNodiscard;
+    BitFlag<0> isMaybeUnused;
     BitFlag<1> isDeprecated;
     BitFlag<2> hasNoUniqueAddress;
 };
@@ -49,7 +49,7 @@ struct FieldInfo
     */
     std::string Default;
 
-    // attributes (nodiscard, no_unique_address, deprecated)
+    // attributes (maybe_unused, no_unique_address, deprecated)
     FieldFlags specs;
 
     //--------------------------------------------

source/-XML/CXXTags.hpp

@@ -172,8 +172,7 @@ inline void write(FieldFlags const& bits, XMLTags& tags)
 {
     BitFieldWriter<FieldFlags> fw(bits, tags);
 
-    // KRYSTIAN FIXME: non-static data members cannot be nodiscard
-    fw.write(&FieldFlags::isNodiscard, "nodiscard");
+    fw.write(&FieldFlags::isMaybeUnused, "maybe-unused");
     fw.write(&FieldFlags::isDeprecated, "deprecated");
     fw.write(&FieldFlags::hasNoUniqueAddress, "no-unique-address");
 }

source/AST/ASTVisitor.cpp

@@ -1277,8 +1277,7 @@ buildField(
 
     I.specs.hasNoUniqueAddress = D->hasAttr<NoUniqueAddressAttr>();
     I.specs.isDeprecated = D->hasAttr<DeprecatedAttr>();
-    // KRYSTIAN FIXME: isNodiscard should be isMaybeUnused
-    I.specs.isNodiscard = D->hasAttr<UnusedAttr>();
+    I.specs.isMaybeUnused = D->hasAttr<UnusedAttr>();
 
     bool member_spec = getParentNamespaces(I.Namespace, D);
 

source/Metadata/DomMetadata.cpp

@@ -787,7 +787,7 @@ DomInfo<T>::construct() const
         entries.insert(entries.end(), {
             { "type", domCreate(I_.Type, corpus_) },
             { "default", dom::stringOrNull(I_.Default) },
-            { "isNodiscard", I_.specs.isNodiscard.get() },
+            { "isMaybeUnused", I_.specs.isMaybeUnused.get() },
             { "isDeprecated", I_.specs.isDeprecated.get() },
             { "hasNoUniqueAddress", I_.specs.hasNoUniqueAddress.get() }
             });

test-files/old-tests/no_unique_address.xml

@@ -13,7 +13,7 @@
     </field>
     <field name="e" id="h2j8f921HD+Fyaokcs4ndGM/yNk=">
       <file path="no_unique_address.cpp" line="8" class="def"/>
-      <attr id="nodiscard"/>
+      <attr id="maybe-unused"/>
       <attr id="deprecated"/>
       <type class="tag" id="iczIHP1J59EwYw3xxL3w2C3Q43Q=" name="Empty"/>
     </field>