don't enter an infinite loop

Author: sdkrystian

source/Metadata/Javadoc.cpp

@@ -89,11 +89,10 @@ postProcess()
         else if(it->kind == Kind::returns)
         {
             if(! returns_)
-            {
                 returns_ = std::make_shared<Returns>(
                     std::move(static_cast<Returns &>(*it)));
-                it = blocks_.erase(it);
-            }
+            // unconditionally consume the Returns element
+            it = blocks_.erase(it);
             // KRYSTIAN TODO: emit a warning for duplicate @returns
             continue;
         }

test-files/old-tests/duplicate-jdoc.cpp

@@ -0,0 +1,38 @@
+/** f0 brief
+    @returns int
+    @returns int
+*/
+int f0() { return 0; }
+
+/** f1 brief
+    @returns int
+    @returns bool
+*/
+int f1() { return 0; }
+
+/** g0 brief
+    @param a one
+    @param a one
+*/
+void g0(int a) { }
+
+/** g1 brief
+    @param a one
+    @param b two
+*/
+void g1(int a) { }
+
+/** h0 brief
+    @tparam T one
+    @tparam T one
+*/
+template<typename T>
+void h0() { }
+
+/** h1 brief
+    @tparam T one
+    @tparam U two
+*/
+template<typename T>
+void h1() { }
+

test-files/old-tests/duplicate-jdoc.xml

@@ -0,0 +1,100 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<mrdox xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+       xsi:noNamespaceSchemaLocation="https://github.com/cppalliance/mrdox/raw/develop/mrdox.rnc">
+<namespace name="">
+  <function name="f1" id="CnO51rIKTzfiVKHkR3TdPa0eo+8=">
+    <file path="duplicate-jdoc.cpp" line="11" class="def"/>
+    <return type="int"/>
+    <doc>
+      <brief>
+        <text>f1 brief</text>
+      </brief>
+      <returns>
+        <text>int</text>
+      </returns>
+      <returns>
+        <text>bool</text>
+      </returns>
+    </doc>
+  </function>
+  <template>
+    <tparam name="T" class="type"/>
+    <function name="h0" id="GUlieEk6E+t8qLpALj3XrWv0CGw=">
+      <file path="duplicate-jdoc.cpp" line="30" class="def"/>
+      <doc>
+        <brief>
+          <text>h0 brief</text>
+        </brief>
+        <tparam name="T">
+          <text>one</text>
+        </tparam>
+        <tparam name="T">
+          <text>one</text>
+        </tparam>
+      </doc>
+    </function>
+  </template>
+  <function name="g0" id="Vn88rrW6JgrUc7j/24MUTRnpkRg=">
+    <file path="duplicate-jdoc.cpp" line="17" class="def"/>
+    <param name="a" type="int"/>
+    <doc>
+      <brief>
+        <text>g0 brief</text>
+      </brief>
+      <param name="a">
+        <text>one</text>
+      </param>
+      <param name="a">
+        <text>one</text>
+      </param>
+    </doc>
+  </function>
+  <function name="f0" id="e1UQQek5v3C9OClW5cGf57XvwQo=">
+    <file path="duplicate-jdoc.cpp" line="5" class="def"/>
+    <return type="int"/>
+    <doc>
+      <brief>
+        <text>f0 brief</text>
+      </brief>
+      <returns>
+        <text>int</text>
+      </returns>
+      <returns>
+        <text>int</text>
+      </returns>
+    </doc>
+  </function>
+  <template>
+    <tparam name="T" class="type"/>
+    <function name="h1" id="q8fclJU+n2M3XqifIjVL9vT9fKQ=">
+      <file path="duplicate-jdoc.cpp" line="37" class="def"/>
+      <doc>
+        <brief>
+          <text>h1 brief</text>
+        </brief>
+        <tparam name="T">
+          <text>one</text>
+        </tparam>
+        <tparam name="U">
+          <text>two</text>
+        </tparam>
+      </doc>
+    </function>
+  </template>
+  <function name="g1" id="99zzvQbBwXKh7ewapNRMnAKND3I=">
+    <file path="duplicate-jdoc.cpp" line="23" class="def"/>
+    <param name="a" type="int"/>
+    <doc>
+      <brief>
+        <text>g1 brief</text>
+      </brief>
+      <param name="a">
+        <text>one</text>
+      </param>
+      <param name="b">
+        <text>two</text>
+      </param>
+    </doc>
+  </function>
+</namespace>
+</mrdox>