Fix filter to show QEMU disks

[kvaps]

Signed-off-by: Andrei Kvapil [email protected]

Summary by CodeRabbit

• Bug Fixes
  • Improved disk discovery logic to now recognize disks identified by either a unique identifier or a model.
  • Standardized the disk detection process, ensuring consistent behavior across various system checks.

[coderabbitai]

Walkthrough

This pull request updates the disk discovery logic within a Helm template. The change modifies the conditional checks to include disks that have either a WWID or a model specified. The update occurs in two locations of the template, ensuring that if either property is present, the disk's device path is correctly assigned and the loop terminates early. No alterations were made to public or exported entities.

Changes

File	Change Summary
charts/talm/templates/_helpers.tpl	Updated disk discovery logic to use if or .spec.wwid .spec.model instead of checking only .spec.wwid, affecting both system_disk_name and disks_info.

Sequence Diagram(s)

sequenceDiagram
    participant TE as Template Engine
    participant DS as Disk Specification

    TE->>DS: Evaluate condition (WWID or Model)
    alt Either WWID or Model exists
        TE->>TE: Set $disk and exit loop
    else Neither exists
        TE-->>TE: Continue scanning for disk info
    end

Loading

Possibly related PRs

• Better system_disk discovery function #43: Adjusts similar conditional checks in the disk discovery logic within the same template file.

Poem

I'm a rabbit with code in my paws,
Hopping through conditions without a pause.
WWID or Model, it matters not the check,
For every disk finds its rightful spec.
In fields of code, I celebrate each change with a joyful hop!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5f8e1c8 and 0789be3.

⛔ Files ignored due to path filters (1)

• pkg/generated/presets.go is excluded by !**/generated/**

📒 Files selected for processing (1)

• charts/talm/templates/_helpers.tpl (2 hunks)

🔇 Additional comments (2)

charts/talm/templates/_helpers.tpl (2)

8-8: Expanded disk selection criteria to include disks with model specifications.

This change broadens the disk detection logic by allowing disks that have either a WWID or a model specification to be considered. This is likely necessary because QEMU virtual disks may not always have a WWID but typically have a model attribute, ensuring these virtual disks are properly detected when determining the system disk.

---

33-33: Enhanced disk listing to include QEMU disks in disk information output.

Similar to the previous change, this modification ensures that disks with either a WWID or a model are included in the disk information output. This change maintains consistency with the system disk detection logic and ensures QEMU disks appear in diagnostic information.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.