Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: COW Amm and JIT treatment in autopilot domain #2723

Closed
sunce86 opened this issue May 13, 2024 · 3 comments
Closed

feat: COW Amm and JIT treatment in autopilot domain #2723

sunce86 opened this issue May 13, 2024 · 3 comments
Assignees
Labels
E:7.1 Ext. solvers operating driver See https://github.com/cowprotocol/pm/issues/57 for details

Comments

@sunce86
Copy link
Contributor

sunce86 commented May 13, 2024

Problem

JIT orders (and particularly COW Amm as it's subset) need to have a special treatment with regards to surplus and score calculation in the autopilot.

  1. Regular JIT orders (that are not part of the Auction) need to be excluded from surplus calculation.
  2. COW Amm orders need to be considered for surplus calculation. COW Amm orders exist in the Auction btw.
  3. COW Amm orders shouldn't have a protocol fee attached.

Two related PRs need to be checked first before implementing:
#2688
#2682

This issue captures work needed to implement this functionality in autopilot::domain::Settlement object.

@sunce86 sunce86 added the E:7.1 Ext. solvers operating driver See https://github.com/cowprotocol/pm/issues/57 for details label May 13, 2024
@sunce86 sunce86 self-assigned this May 14, 2024
@fleupold
Copy link
Contributor

COW Amm orders exist in the Auction btw.

The CoW AMM orders that exist in the auction are placeholders (and likely very different - in terms of amounts - to the ones that end up being proposed by the solvers). What they have in common is the owner.

I think the auction struct should be extended with a field that describes a list of surplus capturing jit order owner (ie all accounts for which solvers are allowed to create jit orders and their surplus will count towards the objective value)

Copy link

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

@github-actions github-actions bot added the stale label Jul 14, 2024
@sunce86 sunce86 removed the stale label Jul 15, 2024
@sunce86
Copy link
Contributor Author

sunce86 commented Sep 7, 2024

Done.

@sunce86 sunce86 closed this as completed Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:7.1 Ext. solvers operating driver See https://github.com/cowprotocol/pm/issues/57 for details
Projects
None yet
Development

No branches or pull requests

2 participants