You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think we should make sure that the for a partially fillable order the "executed amount <= sell amount" and for a killorfill order "executed amount== sell_amount".
Felix noticed that issue due to a bug in the cow-dex-solver, it's providing too big executed amounts, and then we run into this issue. I will try to fix the bug on the cow-dex solver side.
The text was updated successfully, but these errors were encountered:
Currently, the executed amount of an order is not sanity checked.
We just the parsed order.execution_amount from the order
and then based on it calculate the fee amounts:
I think we should make sure that the for a partially fillable order the "executed amount <= sell amount" and for a killorfill order "executed amount== sell_amount".
Felix noticed that issue due to a bug in the cow-dex-solver, it's providing too big executed amounts, and then we run into this issue. I will try to fix the bug on the cow-dex solver side.
The text was updated successfully, but these errors were encountered: