From cea05f8955f2697a070efe75219c06f24b0d5046 Mon Sep 17 00:00:00 2001 From: James Truher Date: Tue, 10 Aug 2021 15:27:28 -0700 Subject: [PATCH] Be sure to open the hitfile with read access. Also, failure to remove the hitfile is not fatal. --- src/coverlet.core/Coverage.cs | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/coverlet.core/Coverage.cs b/src/coverlet.core/Coverage.cs index b296eba57..07e06129d 100644 --- a/src/coverlet.core/Coverage.cs +++ b/src/coverlet.core/Coverage.cs @@ -408,7 +408,7 @@ private void CalculateCoverage() } var documentsList = result.Documents.Values.ToList(); - using (var fs = _fileSystem.NewFileStream(result.HitsFilePath, FileMode.Open)) + using (var fs = _fileSystem.NewFileStream(result.HitsFilePath, FileMode.Open, FileAccess.Read)) using (var br = new BinaryReader(fs)) { int hitCandidatesCount = br.ReadInt32(); @@ -442,8 +442,15 @@ private void CalculateCoverage() } } - _instrumentationHelper.DeleteHitsFile(result.HitsFilePath); - _logger.LogVerbose($"Hit file '{result.HitsFilePath}' deleted"); + try + { + _instrumentationHelper.DeleteHitsFile(result.HitsFilePath); + _logger.LogVerbose($"Hit file '{result.HitsFilePath}' deleted"); + } + catch (Exception ex) + { + _logger.LogWarning($"Unable to remove hit file: {result.HitsFilePath} because : {ex.Message}"); + } } }