From c93c271d2d2eb49ef8188110c26a2b4fc5bfb94e Mon Sep 17 00:00:00 2001 From: Louis Bompart Date: Mon, 8 Dec 2025 16:14:04 -0500 Subject: [PATCH 1/3] fix: support normalized json array for attribute input KIT-5305 --- .../atomic-generated-answer.tsx | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/packages/atomic/src/components/search/atomic-generated-answer/atomic-generated-answer.tsx b/packages/atomic/src/components/search/atomic-generated-answer/atomic-generated-answer.tsx index 171c3e0c4e4..69fb351ac58 100644 --- a/packages/atomic/src/components/search/atomic-generated-answer/atomic-generated-answer.tsx +++ b/packages/atomic/src/components/search/atomic-generated-answer/atomic-generated-answer.tsx @@ -131,7 +131,7 @@ export class AtomicGeneratedAnswer implements InitializableComponent { /** * A list of fields to include with the citations used to generate the answer. */ - @Prop() fieldsToIncludeInCitations?: string; + @Prop() fieldsToIncludeInCitations?: string | string[]; /** * Option to disable citation anchoring. @@ -306,9 +306,21 @@ export class AtomicGeneratedAnswer implements InitializableComponent { ); } + // TODO V4 (KIT-5306): Remove support for string value. + private getCitationFieldsInputArray() { + if( Array.isArray(this.fieldsToIncludeInCitations)) { + return this.fieldsToIncludeInCitations; + } else { + this.bindings.engine.logger.warn( + `Starting from Atomic v4, the "fields-to-include-in-citations" property will only accept an array of strings. Using a string value is now deprecated. Please update the value to be an array of strings. For example: fields-to-include-in-citations='["fieldA","fieldB"]'` + ); + return (this.fieldsToIncludeInCitations ?? '') + .split(',') + } + } + private getCitationFields() { - return (this.fieldsToIncludeInCitations ?? '') - .split(',') + return this.getCitationFieldsInputArray() .map((field) => field.trim()) .filter((field) => field.length > 0) .concat(this.REQUIRED_FIELDS_TO_INCLUDE_IN_CITATIONS) From 973068d8549cd93cc28499eb25f52011b1261650 Mon Sep 17 00:00:00 2001 From: Copilot <198982749+Copilot@users.noreply.github.com> Date: Mon, 8 Dec 2025 18:56:31 -0500 Subject: [PATCH 2/3] refactor: apply code review feedback to getCitationFieldsInputArray (#6739) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: louis-bompart <12366410+louis-bompart@users.noreply.github.com> Co-authored-by: Louis Bompart --- .../atomic-generated-answer.tsx | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/packages/atomic/src/components/search/atomic-generated-answer/atomic-generated-answer.tsx b/packages/atomic/src/components/search/atomic-generated-answer/atomic-generated-answer.tsx index 69fb351ac58..2fcbfd8176a 100644 --- a/packages/atomic/src/components/search/atomic-generated-answer/atomic-generated-answer.tsx +++ b/packages/atomic/src/components/search/atomic-generated-answer/atomic-generated-answer.tsx @@ -307,15 +307,16 @@ export class AtomicGeneratedAnswer implements InitializableComponent { } // TODO V4 (KIT-5306): Remove support for string value. - private getCitationFieldsInputArray() { - if( Array.isArray(this.fieldsToIncludeInCitations)) { + private getCitationFieldsInputArray(): string[] { + if (Array.isArray(this.fieldsToIncludeInCitations)) { return this.fieldsToIncludeInCitations; - } else { + } else if (this.fieldsToIncludeInCitations) { this.bindings.engine.logger.warn( `Starting from Atomic v4, the "fields-to-include-in-citations" property will only accept an array of strings. Using a string value is now deprecated. Please update the value to be an array of strings. For example: fields-to-include-in-citations='["fieldA","fieldB"]'` ); - return (this.fieldsToIncludeInCitations ?? '') - .split(',') + return this.fieldsToIncludeInCitations.split(','); + } else { + return []; } } From 60fb7f257a7f3e91a6b0c1b405806800e7144947 Mon Sep 17 00:00:00 2001 From: "developer-experience-bot[bot]" <91079284+developer-experience-bot[bot]@users.noreply.github.com> Date: Wed, 10 Dec 2025 20:56:59 +0000 Subject: [PATCH 3/3] Add generated files --- packages/atomic/src/components.d.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/atomic/src/components.d.ts b/packages/atomic/src/components.d.ts index 3648e3c0f9b..34e27081d32 100644 --- a/packages/atomic/src/components.d.ts +++ b/packages/atomic/src/components.d.ts @@ -254,7 +254,7 @@ export namespace Components { /** * A list of fields to include with the citations used to generate the answer. */ - "fieldsToIncludeInCitations"?: string; + "fieldsToIncludeInCitations"?: string | string[]; /** * The maximum height (in rem units) of the answer when collapsed. */ @@ -2764,7 +2764,7 @@ declare namespace LocalJSX { /** * A list of fields to include with the citations used to generate the answer. */ - "fieldsToIncludeInCitations"?: string; + "fieldsToIncludeInCitations"?: string | string[]; /** * The maximum height (in rem units) of the answer when collapsed. */