-
Notifications
You must be signed in to change notification settings - Fork 5
feat: add exponential backoff to api core #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
08e7cec
First set of changes
dmbrooke 85d10e4
Use retry mechanism on all requests
dmbrooke 9099031
More constructors, some docs comments
dmbrooke 3a10d3a
Actually leverage OOP :facepalm:
dmbrooke e523534
Further implement options config
dmbrooke 4f8f290
Backoff options fix + tests
dmbrooke d46683c
Improved logic, APICore tests
dmbrooke af774e8
Better docs strings, linting
dmbrooke 31b9b30
Replace custom logic with Resilience4j Retry
dmbrooke cf5d641
Move to older version of resilience4j
dmbrooke 8f9e188
Add samples, undo Source constructor changes
dmbrooke 2a893cd
Linting
dmbrooke 31c1d33
Merge branch 'main' into KIT-2703
dmbrooke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| package com.coveo.pushapiclient; | ||
|
|
||
| public class BackoffOptions { | ||
| public static final int DEFAULT_RETRY_AFTER = 5000; | ||
dmbrooke marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| public static final int DEFAULT_MAX_RETRIES = 50; | ||
| public static final int DEFAULT_TIME_MULTIPLE = 2; | ||
|
|
||
| private final int retryAfter; | ||
| private final int maxRetries; | ||
| private final int timeMultiple; | ||
|
|
||
| public BackoffOptions(int retryAfter, int maxRetries, int timeMultiple) { | ||
| this.retryAfter = retryAfter; | ||
| this.maxRetries = maxRetries; | ||
| this.timeMultiple = timeMultiple; | ||
| } | ||
|
|
||
| public int getRetryAfter() { | ||
| return this.retryAfter; | ||
| } | ||
|
|
||
| public int getMaxRetries() { | ||
| return this.maxRetries; | ||
| } | ||
|
|
||
| public int getTimeMultiple() { | ||
| return this.timeMultiple; | ||
| } | ||
| } | ||
27 changes: 27 additions & 0 deletions
27
src/main/java/com/coveo/pushapiclient/BackoffOptionsBuilder.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| package com.coveo.pushapiclient; | ||
|
|
||
| public class BackoffOptionsBuilder { | ||
|
|
||
| private int retryAfter = BackoffOptions.DEFAULT_RETRY_AFTER; | ||
| private int maxRetries = BackoffOptions.DEFAULT_MAX_RETRIES; | ||
| private int timeMultiple = BackoffOptions.DEFAULT_TIME_MULTIPLE; | ||
|
|
||
| public BackoffOptionsBuilder withRetryAfter(int retryAfter) { | ||
| this.retryAfter = retryAfter; | ||
| return this; | ||
| } | ||
|
|
||
| public BackoffOptionsBuilder withMaxRetries(int maxRetries) { | ||
| this.maxRetries = maxRetries; | ||
| return this; | ||
| } | ||
|
|
||
| public BackoffOptionsBuilder withTimeMultiple(int timeMultiple) { | ||
| this.timeMultiple = timeMultiple; | ||
| return this; | ||
| } | ||
|
|
||
| public BackoffOptions build() { | ||
| return new BackoffOptions(this.retryAfter, this.maxRetries, this.timeMultiple); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.