-
Notifications
You must be signed in to change notification settings - Fork 5
feat: log HTTP calls #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Configure Dependency Review Dependency review helps you understand dependency changes and the security impact of these changes at every pull request. It provides an easily understandable visualization of dependency changes with a rich diff on the "Files Changed" tab of a pull request. The warning for .github/workflows/dependency-review.yml is expected. https://coveord.atlassian.net/browse/DEF-657 J:DEF-657
* ci: add codeql workflow * remove unused option
* chore: use codeql public action * ci: use mvn default arguments from workflow
… Coveo and instance Java classes in different ways (#39)
https://coveord.atlassian.net/browse/LENS-837 --------- Co-authored-by: Benjamin Taillon <[email protected]> Co-authored-by: jpmarceau <[email protected]> Co-authored-by: Mohan Raj Rajamanickam <[email protected]>
* ci: ensure semantic title * ci: remove unnecessary config file
…eturned from StreamServiceInternal (#42) Co-authored-by: Yassine <[email protected]>
* fix: adjust script path * ci: add missing env secrets
* ci: add missing export
* ci: read value from context
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…urity] (#57) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* chore(main): release 2.0.1-SNAPSHOT --------- Co-authored-by: developer-experience-bot[bot] <91079284+developer-experience-bot[bot]@users.noreply.github.com>
Co-authored-by: developer-experience-bot[bot] <91079284+developer-experience-bot[bot]@users.noreply.github.com>
Dependency Review✅ No vulnerabilities or license issues found.Scanned Manifest Filespom.xml
|
louis-bompart
approved these changes
Jun 28, 2023
Contributor
louis-bompart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea!
btaillon-coveo
approved these changes
Jun 28, 2023
This was referenced Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding log4j to log all HTTP calls.
It might not be useful for method performing single HTTP calls like the following example. In these cases, the method already returns the HTTP response.
However, when using complex services (e.g.
PushService,StreamService), documents are batched and multiple HTTP calls are performed.Here is an example of a log output in with log level set to
DEBUG.