Skip to content

Conversation

@hdhayneCoveo
Copy link
Contributor

@hdhayneCoveo hdhayneCoveo commented Jun 6, 2023

this PR contains examples of client code on :

  • Create Push and Catalog Source in Coveo Org
  • instantiate Push and Catalog Source from Url
  • instantiate a Push and Catalog source from platform config (environment , region, platform url)

@hdhayneCoveo hdhayneCoveo requested review from a team, btaillon-coveo, olamothe and y-lakhdar and removed request for a team June 6, 2023 20:17
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

Copy link
Contributor

@y-lakhdar y-lakhdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a couple corrections.
Did you plan add the code samples showing how to actually push data (stream vs push)?

@y-lakhdar
Copy link
Contributor

y-lakhdar commented Jun 7, 2023

❌ Make sure your PR title follows the conventional commit spec:

Example:
docs: add code samples

@hdhayneCoveo hdhayneCoveo changed the title LENS-840 feat: Create Sample Code classes to create push and Catalog Source in Coveo and instance Java classes in different ways Jun 7, 2023
@hdhayneCoveo hdhayneCoveo changed the title feat: Create Sample Code classes to create push and Catalog Source in Coveo and instance Java classes in different ways docs: Create Sample Code classes to create push and Catalog Source in Coveo and instance Java classes in different ways Jun 7, 2023
@hdhayneCoveo
Copy link
Contributor Author

I added a couple corrections. Did you plan add the code samples showing how to actually push data (stream vs push)?

@y-lakhdar yep i can do that , but it wasn't mentioned in the description , i thought it will be part of another task

@y-lakhdar y-lakhdar changed the title docs: Create Sample Code classes to create push and Catalog Source in Coveo and instance Java classes in different ways docs: create Sample Code classes to create push and Catalog Source in Coveo and instance Java classes in different ways Jun 7, 2023
@hdhayneCoveo hdhayneCoveo requested a review from y-lakhdar June 8, 2023 14:42
@hdhayneCoveo hdhayneCoveo merged commit ea3153c into main Jun 8, 2023
@hdhayneCoveo hdhayneCoveo deleted the LENS-840 branch June 8, 2023 17:30
y-lakhdar pushed a commit that referenced this pull request Jun 20, 2023
… Coveo and instance Java classes in different ways (#39)
This was referenced Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants