-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release docs for terraform version V1.4.0 #243
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick scan of the documentation content. Couple of comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding to previous comments
…ved by the docs team Co-authored-by: Simon Dew <[email protected]>
Co-authored-by: Priya Rajagopal <[email protected]> Co-authored-by: Simon Dew <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of my comments from previous review still stand. I'm not requesting changes at this stage so as not to block the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- There are still two top-level headings in this file called Example Usage. Suggest changing the second one to Links to Further Examples or similar.
- Glad to see there are further descriptions under the links. The last few links (from Manage Private Endpoints onward) still just repeat the link text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to dismiss this conversation and merge if you need to progress the PR
Removing previous review as some comments have been addressed
Jira
Description
Release Documentation for Terraform version V1.4.0
Type of Change
Manual Testing Approach
How was this change tested and do you have evidence? (REQUIRED: Select at least 1)
Testing
Testing
Required Checklist:
Further comments