JSCBC-1137: Create and use CppClusterCredentials and CppDnsConfig

interfaces for connection

Motivation
----------
Instead of redefining a credentials object to connect we should use what
is already available from the autogen tooling.

Changes
-------
Create CppClusterCredentials and CppDnsConfig interfaces that are used
when connecting.

Change-Id: Ic77cfaecd163539158093caa4d2b119d282a89d9
Reviewed-on: https://review.couchbase.org/c/couchnode/+/187863
Reviewed-by: Brett Lawson <[email protected]>
Tested-by: Jared Casey <[email protected]>

Author: thejcfactor

lib/binding.ts

@@ -14,6 +14,20 @@ export type CppExpiry = number
 
 export type CppJsonString = string | Buffer
 
+export interface CppClusterCredentials {
+  username?: string
+  password?: string
+  certificate_path?: string
+  key_path?: string
+  allowed_sasl_mechanisms?: string[]
+}
+
+export interface CppDnsConfig {
+  nameserver?: string
+  port?: number
+  dnsSrvTimeout?: number
+}
+
 export interface CppDocumentId {
   bucket: string
   scope: string
@@ -3160,18 +3174,8 @@ export type CppError =
 export interface CppConnection extends CppConnectionAutogen {
   connect(
     connStr: string,
-    credentials: {
-      username?: string
-      password?: string
-      certificate_path?: string
-      key_path?: string
-      allowed_sasl_mechanisms?: string[]
-    },
-    dnsOptions: {
-      nameserver?: string
-      port?: number
-      dnsSrvTimeout?: number
-    } | null,
+    credentials: CppClusterCredentials,
+    dnsOptions: CppDnsConfig | null,
     callback: (err: CppError | null) => void
   ): void
   shutdown(callback: (err: CppError | null) => void): void

lib/cluster.ts

@@ -10,7 +10,7 @@ import {
   PasswordAuthenticator,
   CertificateAuthenticator,
 } from './authenticators'
-import binding, { CppConnection } from './binding'
+import binding, { CppClusterCredentials, CppConnection } from './binding'
 import { errorFromCpp } from './bindingutilities'
 import { Bucket } from './bucket'
 import { BucketManager } from './bucketmanager'
@@ -614,13 +614,7 @@ export class Cluster {
 
       const connStr = dsnObj.toString()
 
-      const authOpts = {
-        username: undefined as string | undefined,
-        password: undefined as string | undefined,
-        certificate_path: undefined as string | undefined,
-        key_path: undefined as string | undefined,
-        allowed_sasl_mechanisms: undefined as string[] | undefined,
-      }
+      const authOpts: CppClusterCredentials = {}
 
       // lets allow `allowed_sasl_mechanisms` to override legacy connstr option
       for (const saslKey of ['sasl_mech_force', 'allowed_sasl_mechanisms']) {
@@ -658,7 +652,6 @@ export class Cluster {
           const err = errorFromCpp(cppErr)
           return reject(err)
         }
-
         resolve(null)
       })
     })