Skip to content

Commit f7737e4

Browse files
committed
Use Base64 encoder/decoder from stdlib
Change-Id: I77de54ba5518a6df8a7b70b5d136eebb5d43a38f Reviewed-on: http://review.couchbase.org/93235 Reviewed-by: Sergey Avseyev <[email protected]> Tested-by: Sergey Avseyev <[email protected]>
1 parent ef541d2 commit f7737e4

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

src/main/java/com/couchbase/mock/security/sasl/ShaSaslServer.java

+6-7
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@
1515
*/
1616
package com.couchbase.mock.security.sasl;
1717

18-
import com.couchbase.mock.util.Base64;
19-
2018
import javax.crypto.Mac;
2119
import javax.crypto.SecretKey;
2220
import javax.crypto.spec.SecretKeySpec;
@@ -33,6 +31,7 @@
3331
import java.security.MessageDigest;
3432
import java.security.NoSuchAlgorithmException;
3533
import java.security.SecureRandom;
34+
import java.util.Base64;
3635
import java.util.HashMap;
3736
import java.util.Map;
3837

@@ -89,7 +88,7 @@ public ShaSaslServer(CallbackHandler cbh, int sha) throws NoSuchAlgorithmExcepti
8988
byte[] randomNonce = new byte[21];
9089
SecureRandom random = new SecureRandom();
9190
random.nextBytes(randomNonce);
92-
serverNonce = Base64.encode(randomNonce);
91+
serverNonce = new String(Base64.getEncoder().encode(randomNonce));
9392
iterationCount = 4096;
9493
}
9594

@@ -154,10 +153,10 @@ private byte[] evaluateClientFinalMessage(byte[] response) {
154153

155154
StringWriter writer = new StringWriter();
156155
writer.append("v=");
157-
writer.append(Base64.encode(serverSignature));
156+
writer.append(new String(Base64.getEncoder().encode(serverSignature)));
158157

159158
// validate the client proof to see if we're getting the same value...
160-
String myClientProof = Base64.encode(getClientProof());
159+
String myClientProof = new String(Base64.getEncoder().encode(getClientProof()));
161160
if (!myClientProof.equals(attributes.get("p"))) {
162161
writer.append(",e=failed");
163162
}
@@ -206,7 +205,7 @@ private byte[] evaluateClientFirstMessage(byte[] response) throws SaslException
206205
throw new IllegalArgumentException("username and client nonce is mandatory in clientFirstMessageBare");
207206
}
208207

209-
salt = Base64.decode("QSXCR+Q6sek8bf92").getBytes();
208+
salt = Base64.getDecoder().decode("QSXCR+Q6sek8bf92");
210209
generateSaltedPassword();
211210

212211
String nonce = clientNonce + serverNonce;
@@ -216,7 +215,7 @@ private byte[] evaluateClientFirstMessage(byte[] response) throws SaslException
216215
writer.append("r=");
217216
writer.append(nonce);
218217
writer.append(",s=");
219-
writer.append(Base64.encode(salt));
218+
writer.append(new String(Base64.getEncoder().encode(salt)));
220219
writer.append(",i=");
221220
writer.append(Integer.toString(iterationCount));
222221

0 commit comments

Comments
 (0)