Skip to content

Commit d77a28a

Browse files
author
Constantin Muraru
committed
Simplify
1 parent 15dca78 commit d77a28a

File tree

1 file changed

+7
-13
lines changed

1 file changed

+7
-13
lines changed

parquet-protobuf/src/main/java/org/apache/parquet/proto/ProtoSchemaConverter.java

+7-13
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,7 @@
3434

3535
import java.util.List;
3636

37-
import static org.apache.parquet.schema.OriginalType.ENUM;
3837
import static org.apache.parquet.schema.OriginalType.UTF8;
39-
import static org.apache.parquet.schema.PrimitiveType.PrimitiveTypeName.BINARY;
4038

4139
/**
4240
* <p/>
@@ -86,26 +84,22 @@ private <T> Builder<? extends Builder<?, GroupBuilder<T>>, GroupBuilder<T>> addF
8684

8785
ParquetType parquetType = getParquetType(descriptor);
8886
if (descriptor.isRepeated()) {
89-
return addRepeatedPrimitive(descriptor, parquetType.primitiveType, builder);
87+
return addRepeatedPrimitive(descriptor, parquetType.primitiveType, parquetType.originalType, builder);
9088
}
9189

9290
return builder.primitive(parquetType.primitiveType, getRepetition(descriptor)).as(parquetType.originalType);
9391
}
9492

9593
private <T> Builder<? extends Builder<?, GroupBuilder<T>>, GroupBuilder<T>> addRepeatedPrimitive(Descriptors.FieldDescriptor descriptor,
96-
PrimitiveTypeName primitiveType, final GroupBuilder<T> builder) {
94+
PrimitiveTypeName primitiveType,
95+
OriginalType originalType,
96+
final GroupBuilder<T> builder) {
9797
GroupBuilder<GroupBuilder<T>> result = builder.group(Type.Repetition.REQUIRED).as(OriginalType.LIST);
9898

99-
if (primitiveType == BINARY) {
100-
OriginalType originalType = descriptor.getJavaType() == JavaType.ENUM ? ENUM : UTF8;
101-
return result
102-
.primitive(primitiveType, Type.Repetition.REPEATED)
103-
.as(originalType)
104-
.named("array");
105-
}
106-
10799
return result
108-
.primitive(primitiveType, Type.Repetition.REPEATED).named("array");
100+
.primitive(primitiveType, Type.Repetition.REPEATED)
101+
.as(originalType)
102+
.named("array");
109103
}
110104

111105
private <T> GroupBuilder<GroupBuilder<T>> addMessageField(Descriptors.FieldDescriptor descriptor, final GroupBuilder<T> builder) {

0 commit comments

Comments
 (0)