Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory usage in soter_asym_cipher_init() #534

Closed
outspace opened this issue Sep 18, 2019 · 2 comments
Closed

memory usage in soter_asym_cipher_init() #534

outspace opened this issue Sep 18, 2019 · 2 comments
Labels

Comments

@outspace
Copy link

I'm look at soter_asym_cipher_init() in BoringSSL and OpenSSL threads. In bad case of macro we call EVP_PKEY_CTX_free than we call EVP_PKEY_CTX_free again in soter_asym_cipher_cleanup that's why it shoud be nulled in BoringSSL too.

@Lagovas
Copy link
Collaborator

Lagovas commented Sep 19, 2019

agree, we should nullify freed pointers to avoid problems with second free call

@ilammy
Copy link
Collaborator

ilammy commented Sep 23, 2019

Resource deallocation has been improved. Stored pointers in key generations routines are now zeroed out after freeing them.

@ilammy ilammy closed this as completed Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants