Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leaks in soter_rsa_key_pair_gen_init() [again] #532

Closed
outspace opened this issue Sep 18, 2019 · 2 comments
Closed

leaks in soter_rsa_key_pair_gen_init() [again] #532

outspace opened this issue Sep 18, 2019 · 2 comments
Labels
bug core Themis Core written in C, its packages

Comments

@outspace
Copy link

I am look at the source code of soter_rsa_key_pair_gen_init() again. I can not understand why we call only EVP_PKEY_CTX_free() in bad case. EVP_PKEY_CTX_new() makes up ref of pkey. EVP_PKEY_CTX_free() make "down ref" of pkey but not free pkey.
Correct me if I'm wrong.

@vixentael vixentael added the core Themis Core written in C, its packages label Sep 19, 2019
@ilammy
Copy link
Collaborator

ilammy commented Sep 23, 2019

The leaks have been plugged.

@ilammy ilammy closed this as completed Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug core Themis Core written in C, its packages
Projects
None yet
Development

No branches or pull requests

4 participants