Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Soft opt out - finish testing #849

Closed
1 of 2 tasks
Tracked by #851
shaspitz opened this issue Apr 13, 2023 · 0 comments · Fixed by #857
Closed
1 of 2 tasks
Tracked by #851

Soft opt out - finish testing #849

shaspitz opened this issue Apr 13, 2023 · 0 comments · Fixed by #857
Assignees
@shaspitz
Labels
scope: testing Code review, testing, making sure the code is following the specification.

Comments

@shaspitz
Copy link
Contributor

shaspitz commented Apr 13, 2023 •
edited by mpoke
Loading

Problem

There are a few loose ends we need to tie up regarding testing of the soft opt out feature. This could be an EPIC, but it didn't seem like there was enough work to warrant one.

Closing criteria

Each task is addressed or deemed unnecessary.

Problem details

We need:

  • proper e2e tests validating the soft opt out feature being enabled
  • optional: enable soft opt out in diff tests and ensure tests pass against model. See Soft opt out diff tests #847, model has been updated but diff tests were failing so soft opt out is disabled.
@shaspitz shaspitz added the status: waiting-triage This issue/PR has not yet been triaged by the team. label Apr 13, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Cosmos Hub Apr 13, 2023
@shaspitz shaspitz moved this from 🩹 Triage to 📥 Todo in Cosmos Hub Apr 13, 2023
@shaspitz shaspitz added scope: testing Code review, testing, making sure the code is following the specification. and removed status: waiting-triage This issue/PR has not yet been triaged by the team. labels Apr 13, 2023
@shaspitz shaspitz changed the title Soft opt out - tie up loose ends Soft opt out - finish testing Apr 14, 2023
@mpoke mpoke mentioned this issue Apr 14, 2023
Closed
@shaspitz shaspitz mentioned this issue Apr 17, 2023
Merged
12 tasks
@github-project-automation github-project-automation bot moved this from 📥 Todo to ✅ Done in Cosmos Hub Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shaspitz shaspitz

Labels
scope: testing Code review, testing, making sure the code is following the specification.
Projects
Cosmos Hub
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

testing: e2e tests for soft opt out cosmos/interchain-security
1 participant
@shaspitz